[BUGFIX beta] Avoid allocating a binding map in meta when possible #12939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, bugfix beta ? Or should this ride the canary train. |
|
Should be completely safe to do that. Even if we did use the binding map on instances, calling |
mmun
force-pushed
the
avoid-alloc-meta-bindings-map
branch
from
5c8c290
to
6c8b6bc
Compare
mmun
changed the title
👍 |
|
@mmun I have noticed many related issues to this over time, thanks for also adding a test. I MUCH suspect more low hanging fruit like this is present. |
stefanpenner
added a commit
that referenced
this pull request
Feb 9, 2016
[BUGFIX beta] Avoid allocating a binding map in meta when possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the
connectBindingsphase of Ember.Object creation would callmeta.clearBindings()on every single object. This causes an extraEmptyObjectto be allocated for everyEmber.Object. The worst part is that it is never used on instances.This change works around the issue making
clearBindingssimply setting_bindingstoundefinedin meta. We could likely remove this field completely if we had separateMetaclasses for instances and classes.